Re: [PATCH v5 09/10] powerpc/fsl_booke/kaslr: support nokaslr cmdline parameter

[Jason Yan]

On 2019/8/7 21:03, Michael Ellerman wrote:
> Jason Yan <yanaijie@xxxxxxxxxx> writes:
> > diff --git a/arch/powerpc/kernel/kaslr_booke.c b/arch/powerpc/kernel/kaslr_booke.c
> > index c6b326424b54..436f9a03f385 100644
> > --- a/arch/powerpc/kernel/kaslr_booke.c
> > +++ b/arch/powerpc/kernel/kaslr_booke.c
> > @@ -361,6 +361,18 @@ static unsigned long __init kaslr_choose_location(void *dt_ptr, phys_addr_t size
> >   	return kaslr_offset;
> >   }
> >   
> > +static inline __init bool kaslr_disabled(void)
> > +{
> > +	char *str;
> > +
> > +	str = strstr(boot_command_line, "nokaslr");
> > +	if (str == boot_command_line ||
> > +	    (str > boot_command_line && *(str - 1) == ' '))
> > +		return true;
>
> This extra logic doesn't work for "nokaslrfoo". Is it worth it?

Seems nobody likes this logic. Maybe I can delete this logic for now and
see if anyone has any objections.

> cheers
>
> .