Re: [PATCH] net/netfilter/nf_nat_proto.c - make tables static

From: Florian Westphal
Date: Thu Aug 08 2019 - 06:33:35 EST


Valdis KlÄtnieks <valdis.kletnieks@xxxxxx> wrote:
> Sparse warns about two tables not being declared.
>
> CHECK net/netfilter/nf_nat_proto.c
> net/netfilter/nf_nat_proto.c:725:26: warning: symbol 'nf_nat_ipv4_ops' was not declared. Should it be static?
> net/netfilter/nf_nat_proto.c:964:26: warning: symbol 'nf_nat_ipv6_ops' was not declared. Should it be static?
>
> And in fact they can indeed be static.

Acked-by: Florian Westphal <fw@xxxxxxxxx>

Seems i removed the static qualifier when i added inet nat support,
but the patch that was merged doesn't use them outside of
nf_nat_proto.c.

Thanks for fixing this.