Re: [PATCH v2 2/2] spi: npcm-fiu: add NPCM FIU controller driver

[Mark Brown]

On Thu, Aug 08, 2019 at 04:14:48PM +0300, Tomer Maimon wrote:

> +	ctrl->mode_bits = SPI_RX_DUAL | SPI_RX_QUAD
> +		| SPI_TX_DUAL | SPI_TX_QUAD;
> +	ctrl->setup = npcm_fiu_setup;

I'm not seeing where we implement dual or quad modes in the driver?
There's some 

> +	dev_info(dev, "NPCM %s probe succeed\n", fiu->info->name);

Just remove this, it makes the log more verbose but doesn't really add
any information.

Attachment: signature.asc
Description: PGP signature