Re: [PATCH v3 2/8] ttm: turn ttm_bo_device.vma_manager into a pointer

From: Gerd Hoffmann
Date: Thu Aug 08 2019 - 09:40:04 EST


Hi,

> > > That would also make the verify_access callback completely superfluous
> > > and looks like a good step into the right direction of de-midlayering.
> >
> > Hmm, right, noticed that too while working on another patch series.
> > Guess I'll try to merge those two and see where I end up ...
>
> ... but if it gets too invasive I'd vote for incremental changes.

Yep, this is what I'm up to. Sketching things up with vram helpers and
qxl, in a way that we can switch over drivers one by one.

Once all drivers are switched removing ttm_bo_device.vma_manager
altogether should be easy.

> Even if
> we completely rip out the vma/mmap lookup stuff from ttm, we still need to
> keep a copy somewhere for vmwgfx.

If vmwgfx is the only user we can probably just move things from ttm to
vmwgfx.

> Or would the evil plan be the vmwgfx
> would use the gem mmap helpers too?

That would work as well ;)

cheers,
Gerd