Re: [PATCH 1/2] mmc: sdhci-of-at91: add quirk for broken HS200
From: Ulf Hansson
Date: Thu Aug 08 2019 - 11:23:39 EST
On Thu, 8 Aug 2019 at 10:35, <Eugen.Hristev@xxxxxxxxxxxxx> wrote:
> From: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx>
> HS200 is not implemented in the driver, but the controller claims it
> through caps.
> Remove it via quirk.
> Without this quirk, the mmc core will try to enable hs200, which will fail,
> and the eMMC initialization will fail.
> Signed-off-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx>
Should this be applied as a fix and possibly tagged for stable?
In such case, do you have a specific commit that it fixes?
> drivers/mmc/host/sdhci-of-at91.c | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
> index 57fe3b2..3a8c6d8 100644
> --- a/drivers/mmc/host/sdhci-of-at91.c
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> @@ -370,6 +370,9 @@ static int sdhci_at91_probe(struct platform_device *pdev)
> pm_runtime_set_autosuspend_delay(&pdev->dev, 50);
> + /* HS200 is broken at this moment */
> + host->quirks2 = SDHCI_QUIRK2_BROKEN_HS200;
> ret = sdhci_add_host(host);
> if (ret)
> goto pm_runtime_disable;