Re: [alsa-devel] [PATCH v2 4/4] ASoC: codecs: add wsa881x amplifier support

[Pierre-Louis Bossart]

> > > +/* 4 ports */
> > > +static struct sdw_dpn_prop wsa_sink_dpn_prop[WSA881X_MAX_SWR_PORTS] = {
> > > +ÂÂÂ {
> > > +ÂÂÂÂÂÂÂ /* DAC */
> > > +ÂÂÂÂÂÂÂ .num = 1,
> > > +ÂÂÂÂÂÂÂ .type = SDW_DPN_SIMPLE,
> >
> > IIRC we added the REDUCED type in SoundWire 1.1 to cover the PDM case 
> > with channel packing (or was it grouping) used by Qualcomm. I am not 
> > sure the SIMPLE type works?
> grouping I guess.
>
> This is a simplified data port as there is no DPn_OffsetCtrl2 register 
> implemented.

ok, for the REDUCED type it's required to have BlockPackingMode and 
OffsetCtrl2, so it does not apply here. Thanks for confirming.