Re: [PATCH] isdn: hysdn: Fix error spaces around '*'

From: Greg KH
Date: Thu Aug 08 2019 - 12:39:11 EST


On Fri, Aug 02, 2019 at 03:05:05PM -0700, Joe Perches wrote:
> On Fri, 2019-08-02 at 14:55 -0700, Stephen Hemminger wrote:
> > On Fri, 2 Aug 2019 19:56:02 +0000
> > Jose Carlos Cazarin Filho <joseespiriki@xxxxxxxxx> wrote:
> >
> > > Fix checkpath error:
> > > CHECK: spaces preferred around that '*' (ctx:WxV)
> > > +extern hysdn_card *card_root; /* pointer to first card */
> > >
> > > Signed-off-by: Jose Carlos Cazarin Filho <joseespiriki@xxxxxxxxx>
> >
> > Read the TODO, these drivers are scheduled for removal, so changes
> > are not helpful at this time.
>
> Maybe better to mark the MAINTAINERS entry obsolete so
> checkpatch bleats a message about unnecessary changes.
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 30bf852e6d6b..b5df91032574 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8628,7 +8628,7 @@ M: Karsten Keil <isdn@xxxxxxxxxxxxxx>
> L: isdn4linux@xxxxxxxxxxxxxxxxxxxxxx (subscribers-only)
> L: netdev@xxxxxxxxxxxxxxx
> W: http://www.isdn4linux.de
> -S: Odd Fixes
> +S: Obsolete
> F: Documentation/isdn/
> F: drivers/isdn/capi/
> F: drivers/staging/isdn/
>

Good idea, will take this patch now, thanks.

greg k-h