Re: [PATCH] clk: fix devm_platform_ioremap_resource.cocci warnings

From: Julia Lawall
Date: Thu Aug 08 2019 - 15:51:40 EST




On Thu, 8 Aug 2019, Stephen Boyd wrote:

> Quoting Julia Lawall (2019-08-08 09:10:53)
> > From: kbuild test robot <lkp@xxxxxxxxx>
> >
> > drivers/clk/bcm/clk-bcm63xx-gate.c:174:1-9: WARNING: Use devm_platform_ioremap_resource for hw -> regs
> >
> > Use devm_platform_ioremap_resource helper which wraps
> > platform_get_resource() and devm_ioremap_resource() together.
> >
> > Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci
> >
> > Fixes: 1c099779c1e2 ("clk: add BCM63XX gated clock controller driver")
>
> Is it fixing anything? As far as I can tell it's reducing lines of code
> with another function.

No, it doesn't fix anything.

julia

>
> > CC: Jonas Gorski <jonas.gorski@xxxxxxxxx>
> > Signed-off-by: kbuild test robot <lkp@xxxxxxxxx>
> > Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx>
>
>