Re: [PATCH v2 1/4] dt-bindings: soundwire: add slave bindings

[Srinivas Kandagatla]

On 09/08/2019 05:54, Vinod Koul wrote:
> On 08-08-19, 20:52, Mark Brown wrote:
> > On Thu, Aug 08, 2019 at 05:48:56PM +0100, Srinivas Kandagatla wrote:
> > > On 08/08/2019 16:58, Pierre-Louis Bossart wrote:
> >
> > > > > +- sdw-instance-id: Should be ('Instance ID') from SoundWire
> > > > > +ÂÂÂÂÂÂÂÂÂ Enumeration Address. Instance ID is for the cases
> > > > > +ÂÂÂÂÂÂÂÂÂ where multiple Devices of the same type or Class
> > > > > +ÂÂÂÂÂÂÂÂÂ are attached to the bus.
> >
> > > > so it is actually required if you have a single Slave device? Or is it
> > > > only required when you have more than 1 device of the same type?
> >
> > > This is mandatory for any slave device!
> >
> > If it's mandatory the wording is a bit unclear.  How about something
> > like:
> >
> > 	Should be ('Instance ID') from the SoundWire Enumeration
> > 	Address.  This must always be provided, if multiple devices
> > 	with the same type or class or attached to the bus each
> > 	instance must have a distinct value.
>
> That helps to make it clear.
>
> Also the section of properties starts with Mandatory property, it should
> be made Mandatory Properties instead, like in other binding docs to make
> it clear that properties mentioned in the section are mandatory

Will update as suggested!

thanks,
srini
>