Re: [PATCH 2/2] lib/test_printf: add test of null/invalid pointer dereference for dentry

From: Andy Shevchenko
Date: Fri Aug 09 2019 - 06:51:37 EST


On Fri, Aug 9, 2019 at 4:28 AM Jia He <justin.he@xxxxxxx> wrote:
>
> This add some additional test cases of null/invalid pointer dereference
> for dentry and file (%pd and %pD)
>

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
> lib/test_printf.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/lib/test_printf.c b/lib/test_printf.c
> index 944eb50f3862..befedffeb476 100644
> --- a/lib/test_printf.c
> +++ b/lib/test_printf.c
> @@ -455,6 +455,13 @@ dentry(void)
> test("foo", "%pd", &test_dentry[0]);
> test("foo", "%pd2", &test_dentry[0]);
>
> + /* test the null/invalid pointer case for dentry */
> + test("(null)", "%pd", NULL);
> + test("(efault)", "%pd", PTR_INVALID);
> + /* test the null/invalid pointer case for file */
> + test("(null)", "%pD", NULL);
> + test("(efault)", "%pD", PTR_INVALID);
> +
> test("romeo", "%pd", &test_dentry[3]);
> test("alfa/romeo", "%pd2", &test_dentry[3]);
> test("bravo/alfa/romeo", "%pd3", &test_dentry[3]);
> --
> 2.17.1
>


--
With Best Regards,
Andy Shevchenko