Re: [PATCH 05/14] gpio: lpc32xx: allow building on non-lpc32xx targets

[Arnd Bergmann]

On Tue, Aug 6, 2019 at 10:02 PM Sylvain Lemieux <slemieux.tyco@xxxxxxxxx> wrote:

> >
> > +       gpio_reg_base = devm_platform_ioremap_resource(pdev, 0);
> > +       if (gpio_reg_base)
> > +               return -ENXIO;
>
> The probe function will always return an error.
> Please replace the previous 2 lines with:
>     if (IS_ERR(gpio_reg_base))
>         return PTR_ERR(gpio_reg_base);
>
> You can add my acked-by and tested-by in the v2 patch.
> Acked-by: Sylvain Lemieux <slemieux.tyco@xxxxxxxxx>
> Tested-by: Sylvain Lemieux <slemieux.tyco@xxxxxxxxx>

Ok, fixed now, along with addressing Bartosz' concerns.

       Arnd