Re: [PATCH -next] crypto: aes-generic - remove unused variable 'rco_tab'

From: Ard Biesheuvel
Date: Fri Aug 09 2019 - 13:50:14 EST


On Fri, 9 Aug 2019 at 11:30, YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
>
> crypto/aes_generic.c:64:18: warning:
> rco_tab defined but not used [-Wunused-const-variable=]
>
> It is never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Acked-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>

> ---
> crypto/aes_generic.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/crypto/aes_generic.c b/crypto/aes_generic.c
> index 71a5c19..22e5867 100644
> --- a/crypto/aes_generic.c
> +++ b/crypto/aes_generic.c
> @@ -61,8 +61,6 @@ static inline u8 byte(const u32 x, const unsigned n)
> return x >> (n << 3);
> }
>
> -static const u32 rco_tab[10] = { 1, 2, 4, 8, 16, 32, 64, 128, 27, 54 };
> -
> /* cacheline-aligned to facilitate prefetching into cache */
> __visible const u32 crypto_ft_tab[4][256] ____cacheline_aligned = {
> {
> --
> 2.7.4
>
>