Re: [PATCH 4.19 36/45] net/mlx5: Fix modify_cq_in alignment

From: Pavel Machek
Date: Sat Aug 10 2019 - 07:25:58 EST


Hi!

> From: Edward Srouji <edwards@xxxxxxxxxxxx>
>
> [ Upstream commit 7a32f2962c56d9d8a836b4469855caeee8766bd4 ]
>
> Fix modify_cq_in alignment to match the device specification.
> After this fix the 'cq_umem_valid' field will be in the right
> offset.

Is it neccessary for v4.19 stable? The cq_umem_valid field is not
there, and it is not needed by subsequent patch.

Best regards,
Pavel

> +++ b/include/linux/mlx5/mlx5_ifc.h
> @@ -5623,7 +5623,12 @@ struct mlx5_ifc_modify_cq_in_bits {
>
> struct mlx5_ifc_cqc_bits cq_context;
>
> - u8 reserved_at_280[0x600];
> + u8 reserved_at_280[0x60];
> +
> + u8 cq_umem_valid[0x1];
> + u8 reserved_at_2e1[0x1f];
> +
> + u8 reserved_at_300[0x580];
>
> u8 pas[0][0x40];
> };
>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature