drivers/dma/fsldma.c:1165:26: warning: this statement may fall through

From: kbuild test robot
Date: Sun Aug 11 2019 - 19:55:28 EST

Next
Previous
Messages

tree: config: powerpc-ppa8548_defconfig compiler: powerpc-linux-gcc reproduce:
wget git checkout # save the GCC_VERSION=7.4.0
If you fix the issue, Reported-by: kbuild
All warnings (new
drivers/dma/fsldma.c: >> drivers/dma/f chan->toggle_ext_pause ~~~~~~~~~~~~~~~~~~~ drivers/dma/fsldma.c:1166:2: case FSL_DMA_IP_83XX:
^~~~

vim +1165 drivers/dma/fsldma.c

a4f56d4b103d4e Ira Snyder 463a1f8b3ceebe Bill Pemberton 77cd62e8082b97 Timur Tabi 173acc7ce8538f Zhang Wei a1c03319018061 Ira Snyder 4ce0e953f62867 Ira Snyder 173acc7ce8538f Zhang Wei 173acc7ce8538f Zhang Wei 173acc7ce8538f Zhang Wei a1c03319018061 Ira Snyder a1c03319018061 Ira Snyder e7a29151de1bd5 Ira Snyder e7a29151de1bd5 Ira Snyder e7a29151de1bd5 Ira Snyder e7a29151de1bd5 Ira Snyder e7a29151de1bd5 Ira Snyder a1c03319018061 Ira Snyder a1c03319018061 Ira Snyder e7a29151de1bd5 Ira Snyder e7a29151de1bd5 Ira Snyder a1c03319018061 Ira Snyder 173acc7ce8538f Zhang Wei 173acc7ce8538f Zhang Wei 4ce0e953f62867 Ira Snyder 173acc7ce8538f Zhang Wei e7a29151de1bd5 Ira Snyder e7a29151de1bd5 Ira Snyder 173acc7ce8538f Zhang Wei 173acc7ce8538f Zhang Wei a1c03319018061 Ira Snyder 173acc7ce8538f Zhang Wei a1c03319018061 Ira Snyder 173acc7ce8538f Zhang Wei e7a29151de1bd5 Ira Snyder e7a29151de1bd5 Ira Snyder e7a29151de1bd5 Ira Snyder 173acc7ce8538f Zhang Wei a1c03319018061 Ira Snyder e7a29151de1bd5 Ira Snyder a1c03319018061 Ira Snyder 8de7a7d95049bd Hongbo Zhang 8de7a7d95049bd Hongbo Zhang 8de7a7d95049bd Hongbo Zhang a1c03319018061 Ira Snyder e7a29151de1bd5 Ira Snyder 173acc7ce8538f Zhang Wei e7a29151de1bd5 Ira Snyder 173acc7ce8538f Zhang Wei 173acc7ce8538f Zhang Wei a1c03319018061 Ira Snyder a1c03319018061 Ira Snyder b158471ef63bf3 Ira Snyder e7a29151de1bd5 Ira Snyder e7a29151de1bd5 Ira Snyder a1c03319018061 Ira Snyder 173acc7ce8538f Zhang Wei 173acc7ce8538f Zhang Wei a1c03319018061 Ira Snyder 173acc7ce8538f Zhang Wei a1c03319018061 Ira Snyder 173acc7ce8538f Zhang Wei a1c03319018061 Ira Snyder 173acc7ce8538f Zhang Wei a1c03319018061 Ira Snyder a1c03319018061 Ira Snyder a1c03319018061 Ira Snyder a1c03319018061 Ira Snyder 173acc7ce8538f Zhang Wei 173acc7ce8538f Zhang Wei a1c03319018061 Ira Snyder 9c3a50b7d7ec45 Ira Snyder 9c3a50b7d7ec45 Ira Snyder 43452fadd614b6 Hongbo Zhang f04cd40701deac Ira Snyder 14c6a3333c8e88 Hongbo Zhang 14c6a3333c8e88 Hongbo Zhang 14c6a3333c8e88 Hongbo Zhang 173acc7ce8538f Zhang Wei a1c03319018061 Ira Snyder 8ac695463f37af Russell 173acc7ce8538f Zhang Wei d3f620b2c4fecd Ira Snyder a1c03319018061 Ira Snyder d3f620b2c4fecd Ira Snyder 173acc7ce8538f Zhang Wei a1c03319018061 Ira Snyder 173acc7ce8538f Zhang Wei a1c03319018061 Ira Snyder aa570be6de67f3 Michael Ellerman 173acc7ce8538f Zhang Wei 173acc7ce8538f Zhang Wei 51ee87f27a1d2c Li Yang e7a29151de1bd5 Ira Snyder a1c03319018061 Ira Snyder a1c03319018061 Ira Snyder a1c03319018061 Ira Snyder e7a29151de1bd5 Ira Snyder 173acc7ce8538f Zhang Wei 173acc7ce8538f Zhang Wei 173acc7ce8538f Zhang Wei
:::::: The code :::::: a1c03319018061304b
:::::: TO: Ira Snyder :::::: CC: Dan Williams
---
0-DAY kernel test infrastructure Attachment: Description: application/gzip message: Andy Lutomirski: "Re: [PATCH] syscalls: Update the syscall #defines to match uapi" message: Gustavo A. R. Silva: "[PATCH][next] ima: ima_modsig: Fix use-after-free bug in ima_read_modsig" sorted by: [ date ] [ thread ] [ subject ] [ author ] href="https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git">https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git master
91766617259261c112db872
048733bb9f2a0dc857ff869 Makefile: Globally enable fall-through warning
(attached as .config)
(GCC) 7.4.0
rel="nofollow" href="https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross">https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
a035d552a93bb9ef6048733bb9f2a0dc857ff869
attached .config to linux build tree
make.cross ARCH=powerpc
kindly add following tag
test robot <lkp@xxxxxxxxx>
ones prefixed by >>):
In function 'fsl_dma_chan_probe':
sldma.c:1165:26: warning: this statement may fall through [-Wimplicit-fallthrough=]
= fsl_chan_toggle_ext_pause;
~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
note: here
2010-01-06 1104
2012-11-19 1105 static int fsl_dma_chan_probe(struct fsldma_device *fdev,
2008-09-26 1106 struct device_node *node, u32 feature, const char *compatible)
2008-03-01 1107 {
2010-01-06 1108 struct fsldma_chan *chan;
2010-01-06 1109 struct resource res;
2008-03-01 1110 int err;
2008-03-01 1111
2008-03-01 1112 /* alloc channel */
2010-01-06 1113 chan = kzalloc(sizeof(*chan), GFP_KERNEL);
2010-01-06 1114 if (!chan) {
2010-01-06 1115 err = -ENOMEM;
2010-01-06 1116 goto out_return;
2010-01-06 1117 }
2010-01-06 1118
2010-01-06 1119 /* ioremap registers for use */
2010-01-06 1120 chan->regs = of_iomap(node, 0);
2010-01-06 1121 if (!chan->regs) {
2010-01-06 1122 dev_err(fdev->dev, "unable to ioremap registers\n");
2010-01-06 1123 err = -ENOMEM;
2010-01-06 1124 goto out_free_chan;
2008-03-01 1125 }
2008-03-01 1126
2010-01-06 1127 err = of_address_to_resource(node, 0, &res);
2008-03-01 1128 if (err) {
2010-01-06 1129 dev_err(fdev->dev, "unable to find 'reg' property\n");
2010-01-06 1130 goto out_iounmap_regs;
2008-03-01 1131 }
2008-03-01 1132
2010-01-06 1133 chan->feature = feature;
2008-03-01 1134 if (!fdev->feature)
2010-01-06 1135 fdev->feature = chan->feature;
2008-03-01 1136
2010-01-06 1137 /*
2010-01-06 1138 * If the DMA device's feature is different than the feature
2010-01-06 1139 * of its channels, report the bug
2008-03-01 1140 */
2010-01-06 1141 WARN_ON(fdev->feature != chan->feature);
2010-01-06 1142
2010-01-06 1143 chan->dev = fdev->dev;
2013-09-26 1144 chan->id = (res.start & 0xfff) < 0x300 ?
2013-09-26 1145 ((res.start - 0x100) & 0xfff) >> 7 :
2013-09-26 1146 ((res.start - 0x200) & 0xfff) >> 7;
2010-01-06 1147 if (chan->id >= FSL_DMA_MAX_CHANS_PER_DEVICE) {
2010-01-06 1148 dev_err(fdev->dev, "too many channels for device\n");
2008-03-01 1149 err = -EINVAL;
2010-01-06 1150 goto out_iounmap_regs;
2008-03-01 1151 }
2008-03-01 1152
2010-01-06 1153 fdev->chan[chan->id] = chan;
2010-01-06 1154 tasklet_init(&chan->tasklet, dma_do_tasklet, (unsigned long)chan);
2011-03-03 1155 snprintf(chan->name, sizeof(chan->name), "chan%d", chan->id);
2010-01-06 1156
2010-01-06 1157 /* Initialize the channel */
2010-01-06 1158 dma_init(chan);
2008-03-01 1159
2008-03-01 1160 /* Clear cdar registers */
2010-01-06 1161 set_cdar(chan, 0);
2008-03-01 1162
2010-01-06 1163 switch (chan->feature & FSL_DMA_IP_MASK) {
2008-03-01 1164 case FSL_DMA_IP_85XX:
2010-01-06 @1165 chan->toggle_ext_pause = fsl_chan_toggle_ext_pause;
2008-03-01 1166 case FSL_DMA_IP_83XX:
2010-01-06 1167 chan->toggle_ext_start = fsl_chan_toggle_ext_start;
2010-01-06 1168 chan->set_src_loop_size = fsl_chan_set_src_loop_size;
2010-01-06 1169 chan->set_dst_loop_size = fsl_chan_set_dst_loop_size;
2010-01-06 1170 chan->set_request_count = fsl_chan_set_request_count;
2008-03-01 1171 }
2008-03-01 1172
2010-01-06 1173 spin_lock_init(&chan->desc_lock);
2010-01-06 1174 INIT_LIST_HEAD(&chan->ld_pending);
2010-01-06 1175 INIT_LIST_HEAD(&chan->ld_running);
2014-05-21 1176 INIT_LIST_HEAD(&chan->ld_completed);
2011-03-03 1177 chan->idle = true;
2014-05-21 1178 #ifdef CONFIG_PM
2014-05-21 1179 chan->pm_state = RUNNING;
2014-05-21 1180 #endif
2008-03-01 1181
2010-01-06 1182 chan->common.device = &fdev->common;
King - ARM Linux 2012-03-06 1183 dma_cookie_init(&chan->common);
2008-03-01 1184
2010-01-06 1185 /* find the IRQ line, if it exists in the device tree */
2010-01-06 1186 chan->irq = irq_of_parse_and_map(node, 0);
2010-01-06 1187
2008-03-01 1188 /* Add the channel to DMA device channel list */
2010-01-06 1189 list_add_tail(&chan->common.device_node, &fdev->common.channels);
2008-03-01 1190
2010-01-06 1191 dev_info(fdev->dev, "#%d (%s), irq %d\n", chan->id, compatible,
2016-09-10 1192 chan->irq ? chan->irq : fdev->irq);
2008-03-01 1193
2008-03-01 1194 return 0;
2008-05-29 1195
2010-01-06 1196 out_iounmap_regs:
2010-01-06 1197 iounmap(chan->regs);
2010-01-06 1198 out_free_chan:
2010-01-06 1199 kfree(chan);
2010-01-06 1200 out_return:
2008-03-01 1201 return err;
2008-03-01 1202 }
2008-03-01 1203
at line 1165 was first introduced by commit
e28d131073ac13a5cb86fb fsldma: rename fsl_chan to chan
<iws@xxxxxxxxxxxxxxxx>
<dan.j.williams@xxxxxxxxx>
Open Source Technology Center
href="https://lists.01.org/pipermail/kbuild-all">https://lists.01.org/pipermail/kbuild-all Intel Corporation
>.config.gz

Next message: Andy Lutomirski: "Re: [PATCH] syscalls: Update the syscall #defines to match uapi"
Previous message: Gustavo A. R. Silva: "[PATCH][next] ima: ima_modsig: Fix use-after-free bug in ima_read_modsig"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]