Re: [PATCH][net-next] rxrpc: fix uninitialized return value in variable err

From: David Miller
Date: Mon Aug 12 2019 - 00:22:27 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Fri, 9 Aug 2019 18:02:59 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> An earlier commit removed the setting of err to -ENOMEM so currently
> the skb_shinfo(skb)->nr_frags > 16 check returns with an uninitialized
> bogus return code. Fix this by setting err to -ENOMEM to restore
> the original behaviour.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: b214b2d8f277 ("rxrpc: Don't use skb_cow_data() in rxkad")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

David, I assume you will pick this up.