Re: [PATCH v3] perf diff: Report noisy for cycles diff

[Jiri Olsa]

On Sat, Aug 10, 2019 at 07:30:29AM +0800, Jin Yao wrote:

SNIP

> +		if (vals[i] != 0)
> +			return 0;
> +	return 1;
> +}
> +
> +static int print_cycles_spark(char *bf, int size, unsigned long *svals, u64 n)
> +{
> +	int len = n, printed;
> +
> +	if (len <= 1)
> +		return 0;
> +
> +	if (len > NUM_SPARKS)
> +		len = NUM_SPARKS;
> +	if (all_zero(svals, len))
> +		return 0;
> +
> +	printed = print_spark(bf, size, svals, len);
> +	printed += scnprintf(bf + printed, size - printed, " ");
> +
> +	if (n > NUM_SPARKS)
> +		printed += scnprintf(bf + printed, size - printed, "..");

will this '..' ever be printed? I can't see that even if I enlarge
the column width..

jirka