RE: [PATCH] dmaengine: fsldma: Mark expected switch fall-through

[Leo Li]

> -----Original Message-----
> From: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> Sent: Sunday, August 11, 2019 7:22 PM
> To: Leo Li <leoyang.li@xxxxxxx>; Zhang Wei <zw@xxxxxxxxxxxxx>; Vinod
> Koul <vkoul@xxxxxxxxxx>; Dan Williams <dan.j.williams@xxxxxxxxx>
> Cc: linuxppc-dev@xxxxxxxxxxxxxxxx; dmaengine@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> Subject: [PATCH] dmaengine: fsldma: Mark expected switch fall-through
> 
> Mark switch cases where we are expecting to fall through.
> 
> Fix the following warning (Building: powerpc-ppa8548_defconfig powerpc):
> 
> drivers/dma/fsldma.c: In function âfsl_dma_chan_probeâ:
> drivers/dma/fsldma.c:1165:26: warning: this statement may fall through [-
> Wimplicit-fallthrough=]
>    chan->toggle_ext_pause = fsl_chan_toggle_ext_pause;
>    ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/dma/fsldma.c:1166:2: note: here
>   case FSL_DMA_IP_83XX:
>   ^~~~
> 
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>

Acked-by: Li Yang <leoyang.li@xxxxxxx>

> ---
>  drivers/dma/fsldma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index
> 23e0a356f167..ad72b3f42ffa 100644
> --- a/drivers/dma/fsldma.c
> +++ b/drivers/dma/fsldma.c
> @@ -1163,6 +1163,7 @@ static int fsl_dma_chan_probe(struct
> fsldma_device *fdev,
>  	switch (chan->feature & FSL_DMA_IP_MASK) {
>  	case FSL_DMA_IP_85XX:
>  		chan->toggle_ext_pause = fsl_chan_toggle_ext_pause;
> +		/* Fall through */
>  	case FSL_DMA_IP_83XX:
>  		chan->toggle_ext_start = fsl_chan_toggle_ext_start;
>  		chan->set_src_loop_size = fsl_chan_set_src_loop_size;
> --
> 2.22.0