Re: [PATCH v2] net: phy: at803x: stop switching phy delay config needlessly

From: David Miller
Date: Mon Aug 12 2019 - 17:02:52 EST


From: André Draszik <git@xxxxxxxxxx>
Date: Fri, 9 Aug 2019 12:20:25 +0100

> This driver does a funny dance disabling and re-enabling
> RX and/or TX delays. In any of the RGMII-ID modes, it first
> disables the delays, just to re-enable them again right
> away. This looks like a needless exercise.
>
> Just enable the respective delays when in any of the
> relevant 'id' modes, and disable them otherwise.
>
> Also, remove comments which don't add anything that can't be
> seen by looking at the code.
>
> Signed-off-by: André Draszik <git@xxxxxxxxxx>

Applied.