Re: [PATCH v2] regulator: core: Add of_node_put() before return

[Nishka Dasgupta]

On 08/08/19 5:57 PM, Mark Brown wrote:
> On Thu, Aug 08, 2019 at 12:35:53PM +0530, Nishka Dasgupta wrote:
> > In function of_get_child_regulator(), the loop for_each_child_of_node()
> > contains two mid-loop return statements. Ordinarily the loop gets the
> > node child at the beginning of every iteration and automatically puts
>
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code.  Modifying existing
> commits creates problems for other users building on top of those
> commits so it's best practice to only change pubished git commits if
> absolutely essential.
I am very sorry about this; I wasn't sure whether this particular commit 
had been applied. Should I split the commit and resend only the change 
to the old commit, or should I leave it as it is?

Thanking you,
Nishka