Re: [PATCH v12 10/18] kunit: test: add tests for kunit test abort

From: Brendan Higgins
Date: Tue Aug 13 2019 - 01:06:18 EST


On Mon, Aug 12, 2019 at 9:24 PM Stephen Boyd <sboyd@xxxxxxxxxx> wrote:
>
> Quoting Brendan Higgins (2019-08-12 11:24:13)
> > +
> > +static int kunit_try_catch_test_init(struct kunit *test)
> > +{
> > + struct kunit_try_catch_test_context *ctx;
> > +
> > + ctx = kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL);
>
> Can this fail? Should return -ENOMEM in that case?

Yes, I should do that.

> > + test->priv = ctx;
> > +
> > + ctx->try_catch = kunit_kmalloc(test,
> > + sizeof(*ctx->try_catch),
> > + GFP_KERNEL);