Re: [PATCH 3/3] staging: erofs: xattr.c: avoid BUG_ON

From: Chao Yu
Date: Tue Aug 13 2019 - 02:26:43 EST


Hi Xiang,

On 2019/8/13 11:57, Gao Xiang wrote:
> Hi Chao,
>
> On Tue, Aug 13, 2019 at 11:20:22AM +0800, Chao Yu wrote:
>> On 2019/8/13 10:30, Gao Xiang wrote:
>>> Kill all the remaining BUG_ON in EROFS:
>>> - one BUG_ON was used to detect xattr on-disk corruption,
>>> proper error handling should be added for it instead;
>>> - the other BUG_ONs are used to detect potential issues,
>>> use DBG_BUGON only in (eng) debugging version.
>>
>> BTW, do we need add WARN_ON() into DBG_BUGON() to show some details function or
>> call stack in where we encounter the issue?
>
> Thanks for kindly review :)
>
> Agreed, it seems much better. If there are no other considerations
> here, I can submit another patch addressing it later or maybe we
> can change it in the next linux version since I'd like to focusing
> on moving out of staging for this round...

No problem, we can change it in a proper time.

Thanks,

>
> Thanks,
> Gao Xiang
>
>>
>>>
>>> Signed-off-by: Gao Xiang <gaoxiang25@xxxxxxxxxx>
>>
>> Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>
>>
>> Thanks,
> .
>