Re: [PATCH 2/2] mm/vmalloc: use generated callback to populate subtree_max_size

From: Uladzislau Rezki
Date: Tue Aug 13 2019 - 05:02:34 EST


On Sun, Aug 11, 2019 at 05:39:23PM -0700, Michel Lespinasse wrote:
> On Sun, Aug 11, 2019 at 11:46 AM Uladzislau Rezki (Sony)
> <urezki@xxxxxxxxx> wrote:
> > RB_DECLARE_CALLBACKS_MAX defines its own callback to update the
> > augmented subtree information after a node is modified. It makes
> > sense to use it instead of our own propagate implementation.
> >
> > Apart of that, in case of using generated callback we can eliminate
> > compute_subtree_max_size() function and get rid of duplication.
> >
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>
>
> Reviewed-by: Michel Lespinasse <walken@xxxxxxxxxx>
>
> Love it. Thanks a lot for the cleanup!
Thank you for review!

--
Vlad Rezki