Re: [PATCH v3 2/2] bus: ti-sysc: sysc_check_children(): Change return type to void
From: Tony Lindgren
Date: Tue Aug 13 2019 - 07:43:01 EST
* Roger Quadros <rogerq@xxxxxx> [190813 11:14]:
>
> On 13/08/2019 10:55, Nishka Dasgupta wrote:
> > Change return type of function sysc_check_children() from int to void as
> > it always returns 0. Remove its return statement as well.
> > At call site, remove the variable that was used to store the return
> > value, as well as the check on the return value.
> >
>
> You don't need to describe each and everything as it is obvious
> from code. How about?
> "Change return type of sysc_check_children() to "void"
> as it never returns error"
>
> Should both patches can be squashed into one patch?
Sure why not, makes it easier to follow :)
Regards,
Tony