Re: [PATCH v2 09/10] usb-storage: remove single-use define for debugging

From: Greg KH
Date: Tue Aug 13 2019 - 08:43:04 EST


On Tue, Aug 13, 2019 at 01:17:06PM +0100, Matthias Maennich wrote:
> USB_STORAGE was defined as "usb-storage: " and used in a single location
> as argument to printk. In order to be able to use the name
> 'USB_STORAGE', drop the definition and use the string directly for the
> printk call.
>
> Signed-off-by: Matthias Maennich <maennich@xxxxxxxxxx>
> ---
> drivers/usb/storage/debug.h | 2 --
> drivers/usb/storage/scsiglue.c | 2 +-
> 2 files changed, 1 insertion(+), 3 deletions(-)

I'll go take this today. The module really should just be using
dev_err() there. It needs to be cleaned up :(

thanks,

greg k-h