Re: [PATCH v2 10/10] RFC: usb-storage: export symbols in USB_STORAGE namespace

From: Greg KH
Date: Tue Aug 13 2019 - 08:47:14 EST


On Tue, Aug 13, 2019 at 01:17:07PM +0100, Matthias Maennich wrote:
> Modules using these symbols are required to explicitly import the
> namespace. This patch was generated with the following steps and serves
> as a reference to use the symbol namespace feature:
>
> 1) Define DDEFAULT_SYMBOL_NAMESPACE in the corresponding Makefile
> 2) make (see warnings during modpost about missing imports)
> 3) make nsdeps
>
> Instead of a DEFAULT_SYMBOL_NAMESPACE definition, the EXPORT_SYMBOL_NS
> variants can be used to explicitly specify the namespace. The advantage
> of the method used here is that newly added symbols are automatically
> exported and existing ones are exported without touching their
> respective EXPORT_SYMBOL macro expansion.

Ok, I can't read text, this answers my previous question.

But, as an example, shouldn't we also have some code here that uses the
EXPORT_SYMBOL_NS() macro to ensure that it actually works?

thanks,

greg k-h