Re: [alsa-devel] [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream()

[Pierre-Louis Bossart]

On 8/13/19 2:18 PM, Mark Brown wrote:
> On Tue, Aug 13, 2019 at 02:15:18PM -0500, Pierre-Louis Bossart wrote:
> > On 8/13/19 1:06 PM, Srinivas Kandagatla wrote:
>
> > > sorry for the confusion. It was too quick reply. :-)
> > > I was suppose to say sdw_stream_add_slave() instead of set_sdw_stream().
>
> > ok, so get_sdw_stream() and set_sdw_stream() are not meant to be mirrors or
> > both implemented. It's just a helper to respectively get a context or set a
> > context but a get-modify-set type of operation is not expected.
>
> > Do I get this right?
>
> This seems like it's going to be confusing...

Indeed. I don't have a full understanding of that part to be honest, nor 
why we need something SoundWire-specific. We already abused the 
set_tdm_slot API to store an HDaudio stream, now we have a rather 
confusing stream information for SoundWire and I have about 3 other 
'stream' contexts in SOF... I am still doing basic cleanups but this has 
been on my radar for a while.