RE: [EXT] Re: [v2 2/3] dt/bindings: display: Add optional property node defined for Mali DP500

[Wen He]

> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: 2019年8月13日 7:20
> To: Wen He <wen.he_1@xxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; mark.rutland@xxxxxxx; liviu.dudau@xxxxxxx;
> brian.starkey@xxxxxxx; airlied@xxxxxxxx; daniel@xxxxxxxx; Leo Li
> <leoyang.li@xxxxxxx>
> Subject: [EXT] Re: [v2 2/3] dt/bindings: display: Add optional property node
> defined for Mali DP500
> 
> 
> On Fri, Jul 19, 2019 at 05:58:42PM +0800, Wen He wrote:
> > Add optional property node 'arm,malidp-arqos-value' for the Mali DP500.
> > This property describe the ARQoS levels of DP500's QoS signaling.
> >
> > Signed-off-by: Wen He <wen.he_1@xxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/display/arm,malidp.txt | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/arm,malidp.txt
> b/Documentation/devicetree/bindings/display/arm,malidp.txt
> > index 2f7870983ef1..76a0e7251251 100644
> > --- a/Documentation/devicetree/bindings/display/arm,malidp.txt
> > +++ b/Documentation/devicetree/bindings/display/arm,malidp.txt
> > @@ -37,6 +37,8 @@ Optional properties:
> >
> Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt)
> >      to be used for the framebuffer; if not present, the framebuffer may
> >      be located anywhere in memory.
> > +  - arm,malidp-arqos-high-level: integer of u32 value describing the ARQoS
> > +    levels of DP500's QoS signaling.
> 
> u32 here, and...

Hi Rob,

Sorry, should be written as" phandle to a node describing the AQRoS levels of DP500's QoS signaling"..
Is that ok?

Best Regards,
Wen

> 
> >
> >
> >  Example:
> > @@ -54,6 +56,7 @@ Example:
> >               clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>,
> <&fpgaosc1>;
> >               clock-names = "pxlclk", "mclk", "aclk", "pclk";
> >               arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> > +             arm,malidp-arqos-high-level = <&rqosvalue>;
> 
> phandle here?
> 
> >               port {
> >                       dp0_output: endpoint {
> >                               remote-endpoint = <&tda998x_2_input>;
> > --
> > 2.17.1
> >