Re: [PATCH RESEND 2/2] staging: erofs: differentiate unsupported on-disk format
From: Gao Xiang
Date: Wed Aug 14 2019 - 05:32:39 EST
Hi Chao,
On Wed, Aug 14, 2019 at 05:25:51PM +0800, Chao Yu wrote:
> On 2019/8/14 12:32, Gao Xiang wrote:
> > For some specific fields, use ENOTSUPP instead of EIO
> > for values which look sane but aren't supported right now.
> >
> > Signed-off-by: Gao Xiang <gaoxiang25@xxxxxxxxxx>
>
> Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>
>
> > + return -ENOTSUPP;
>
> A little bit confused about when we need to use ENOTSUPP or EOPNOTSUPP, I
> checked several manual of syscall, it looks EOPNOTSUPP is widely used.
It seems that you are right, I didn't notice this.
Let me resend this patchset to fix them all...
Thanks,
Gao Xiang
>
> Thanks,