Re: [PATCH v4 13/14] net: phy: adin: add ethtool get_stats support

From: Andrew Lunn
Date: Wed Aug 14 2019 - 10:04:22 EST

Next message: Paolo Bonzini: "Re: [PATCH RESEND v4 0/9] Enable Sub-page Write Protection Support"
Previous message: Christoph Hellwig: "[PATCH 2/2] microblaze: use the generic dma coherent remap allocator"
In reply to: Ardelean, Alexandru: "Re: [PATCH v4 13/14] net: phy: adin: add ethtool get_stats support"
Next in thread: Alexandru Ardelean: "[PATCH v4 10/14] net: phy: adin: implement PHY subsystem software reset"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> So, I have to apologize again here.
> I guess I was an idiot/n00b about this.

Not a problem. If it is not something you have come across before, you
can easily miss the significance.

So you just need to modify the ordering and you are good to go.
Please add a comment in the code about this latching. We don't want
somebody changing the ordering and breaking it.

Thanks
Andrew

Next message: Paolo Bonzini: "Re: [PATCH RESEND v4 0/9] Enable Sub-page Write Protection Support"
Previous message: Christoph Hellwig: "[PATCH 2/2] microblaze: use the generic dma coherent remap allocator"
In reply to: Ardelean, Alexandru: "Re: [PATCH v4 13/14] net: phy: adin: add ethtool get_stats support"
Next in thread: Alexandru Ardelean: "[PATCH v4 10/14] net: phy: adin: implement PHY subsystem software reset"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]