Re: [PATCH v2] nvme: Add quirk for LiteON CL1 devices running FW 22301111
From: Keith Busch
Date: Wed Aug 14 2019 - 16:11:05 EST
On Wed, Aug 14, 2019 at 01:08:24PM -0700, Mario Limonciello wrote:
> One of the components in LiteON CL1 device has limitations that
> can be encountered based upon boundary race conditions using the
> nvme bus specific suspend to idle flow.
>
> When this situation occurs the drive doesn't resume properly from
> suspend-to-idle.
>
> LiteON has confirmed this problem and fixed in the next firmware
> version. As this firmware is already in the field, avoid running
> nvme specific suspend to idle flow.
>
> Fixes: d916b1be94b6 ("nvme-pci: use host managed power state for suspend")
> Link: http://lists.infradead.org/pipermail/linux-nvme/2019-July/thread.html
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxxx>
> Signed-off-by: Charles Hyde <charles.hyde@xxxxxxxxxxxx>
Looks fine to me.
Reviewed-by: Keith Busch <kbusch@xxxxxxxxxx>