Re: [PATCH 4.19 00/91] 4.19.67-stable review

[Guenter Roeck]

On 8/15/19 6:58 AM, Daniel DÃaz wrote:
> Hello!
>
> On Thu, 15 Aug 2019 at 08:29, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > On 8/14/19 10:00 AM, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 4.19.67 release.
> > > There are 91 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Fri 16 Aug 2019 04:55:34 PM UTC.
> > > Anything received after that time might be too late.
> >
> > Building x86_64:tools/perf ... failed
> > --------------
> > Error log:
> > Warning: arch/x86/include/asm/cpufeatures.h differs from kernel
> > Warning: arch/x86/include/uapi/asm/kvm.h differs from kernel
> >     PERF_VERSION = 4.9.189.ge000f87
> > util/machine.c: In function âmachine__create_moduleâ:
> > util/machine.c:1088:43: error: âsizeâ undeclared (first use in this function); did you mean âdieâ?
> >     if (arch__fix_module_text_start(&start, &size, name) < 0)
> >                                              ^~~~
> >                                              die
> > util/machine.c:1088:43: note: each undeclared identifier is reported only once for each function it appears in
>
> We noticed this exact failure but not on 4.19. For us, 4.19's perf builds fine.
>
> On 4.9, perf failed with the error you described, as it looks like
> it's missing 9ad4652b66f1 ("perf record: Fix wrong size in
> perf_record_mmap for last kernel module"), though I have not verified
> yet.

Uuh, yes, you are correct. I wasn't paying attention (blaming lack of coffee
in the morning). The above error is from v4.9.y.queue, not v4.19.y.queue.

Sorry for the confusion.

Guenter