Re: [PATCH] clk: sunxi: Don't call clk_hw_get_name() on a hw that isn't registered

From: Stephen Boyd
Date: Thu Aug 15 2019 - 11:18:49 EST


Quoting Maxime Ripard (2019-08-15 01:01:46)
> On Wed, Aug 14, 2019 at 09:10:37PM -0700, Stephen Boyd wrote:
> > The implementation of clk_hw_get_name() relies on the clk_core
> > associated with the clk_hw pointer existing. If of_clk_hw_register()
> > fails, there isn't a clk_core created yet, so calling clk_hw_get_name()
> > here fails. Extract the name first so we can print it later.
> >
> > Fixes: 1d80c14248d6 ("clk: sunxi-ng: Add common infrastructure")
> > Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>
> > Cc: Chen-Yu Tsai <wens@xxxxxxxx>
> > Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxx>
>
> Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>
>
> Do you want to apply it yourself, or should I merge this and send you
> a PR later?
>

I can apply it myself. Thanks! Now to figure out the real problem...