Re: [PATCH v5 0/2] usbip: Implement SG support
From: Suwan Kim
Date: Thu Aug 15 2019 - 11:25:53 EST
On Thu, Aug 15, 2019 at 08:10:49AM -0600, shuah wrote:
> On 8/15/19 7:23 AM, Greg KH wrote:
> > On Wed, Aug 14, 2019 at 06:19:51AM -0700, Christoph Hellwig wrote:
> > > FYI, I think my
> > >
> > > "usb: add a HCD_DMA flag instead of guestimating DMA capabilities"
> > >
> > > is the proper core fix for what your patch 1 works around, as the USB
> > > core should not assume DMA capabilities based on the presence of a DMA
> > > mask.
> >
> > I agree. Let's wait for Christoph's series to be applied before taking
> > this one.
> >
>
> Great. Thanks you both looking at these. Makes sense.
Ok. Then I will drop the patch 1 and leave vhci flags without
including the HCD_DMA flag to skip dma mapping.
BTW, in my patch 2, I set URB_DMA_MAP_SG flag in
vhci_map_urb_for_dma() of patch 1 to tell the server to use SG.
I will fix it by setting URB_DMA_MAP_SG flag in other place and
resend v6. Is it ok?
Regards
Suwan Kim