Re: [PATCH v4 4/8] printk: Replace strncmp with str_has_prefix
From: Chuhong Yuan
Date: Thu Aug 15 2019 - 11:33:15 EST
On Thu, Aug 15, 2019 at 9:52 PM Petr Mladek <pmladek@xxxxxxxx> wrote:
>
> On Thu 2019-08-15 16:50:33, Sergey Senozhatsky wrote:
> > On (08/14/19 12:49), Petr Mladek wrote:
> > > On Fri 2019-08-09 15:10:34, Chuhong Yuan wrote:
> > > > strncmp(str, const, len) is error-prone because len
> > > > is easy to have typo.
> > > > The example is the hard-coded len has counting error
> > > > or sizeof(const) forgets - 1.
> > > > So we prefer using newly introduced str_has_prefix()
> > > > to substitute such strncmp to make code better.
> > > >
> > > > Signed-off-by: Chuhong Yuan <hslester96@xxxxxxxxx>
> > >
> > > Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
> >
> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
>
> Chuong Yuan, should I take this patch via printk.git? Or will
> the entire series go via some other tree, please?
>
I think that it goes via printk.git is okay, thanks!
> Best Regards,
> Petr