Re: [PATCH] net: pch_gbe: Fix memory leaks

From: David Miller
Date: Thu Aug 15 2019 - 15:34:32 EST


From: Wenwen Wang <wenwen@xxxxxxxxxx>
Date: Tue, 13 Aug 2019 20:33:45 -0500

> In pch_gbe_set_ringparam(), if netif_running() returns false, 'tx_old' and
> 'rx_old' are not deallocated, leading to memory leaks. To fix this issue,
> move the free statements after the if branch.
>
> Signed-off-by: Wenwen Wang <wenwen@xxxxxxxxxx>

Why would they be "deallocated"? They are still assigned to
adapter->tx_ring and adapter->rx_ring.