Re: [PATCH net-next] r8152: divide the tx and rx bottom functions

From: David Miller
Date: Thu Aug 15 2019 - 16:58:53 EST


From: Hayes Wang <hayeswang@xxxxxxxxxxx>
Date: Wed, 14 Aug 2019 16:30:17 +0800

> Move the tx bottom function from NAPI to a new tasklet. Then, for
> multi-cores, the bottom functions of tx and rx may be run at same
> time with different cores. This is used to improve performance.
>
> Signed-off-by: Hayes Wang <hayeswang@xxxxxxxxxxx>

Theoretically, yes.

But do you have actual performance numbers showing this to be worth
the change?

Always provide performance numbers with changes that are supposed to
improve performance.