Re: [PATCH] mtd: rawnand: Fix a memory leak bug

From: kbuild test robot
Date: Sun Aug 18 2019 - 17:36:18 EST

Next message:
Previous message:
In reply to:
Messages sorted by:
Hi Wenwen,

Thank you for the patch! Yet something
[auto build test ERROR on linus/master]
url: .config.gz Description: application/gzipJoel Fernandes (Google): "[RFC] rcu/tree: Try to invoke_rcu_core() if in_irq() during unlock" Stephen Rothwell: "linux-next: Fixes tag needs some work in the net tree" Wenwen Wang: "[PATCH] mtd: rawnand: Fix a memory leak bug" href="date.html#01537">[ date ] [ thread ] [ subject ] [ author ] to improve: > r> wrong git tree, please drop us a note to help improve the system] ithub.com/0day-ci/linux/commits/Wenwen-Wang/mtd-rawnand-Fix-a-memory-leak-bug/20190819-045011">https://github.com/0day-ci/linux/commits/Wenwen-Wang/mtd-rawnand-Fix-a-memory-leak-bug/20190819-045011 as .config) 7.4.0 s://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross">https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross to linux build tree ARCH=sparc64 following tag xxxxxx> >>): In function 'nand_scan_bbt': error: label 'err' used but not defined bbt.c Sebastian Andrzej Siewior 2010-09-30 1198 Sebastian Andrzej Siewior 2010-09-30 1199 /** Linus Torvalds 2005-04-16 1200 * nand_scan_bbt - [NAND Interface] scan, find, read and maybe create bad block table(s) Boris Brezillon 2018-11-11 1201 * @this: the NAND device Linus Torvalds 2005-04-16 1202 * @bd: descriptor for the good/bad block search pattern Linus Torvalds 2005-04-16 1203 * Brian Norris 2011-05-25 1204 * The function checks, if a bad block table(s) is/are already available. If Brian Norris 2011-05-25 1205 * not it scans the device for manufacturer marked good / bad blocks and writes Brian Norris 2011-05-25 1206 * the bad block table(s) to the selected place. Linus Torvalds 2005-04-16 1207 * Brian Norris 2011-05-25 1208 * The bad block table memory is allocated here. It must be freed by calling Brian Norris 2011-05-25 1209 * the nand_free_bbt function. Linus Torvalds 2005-04-16 1210 */ Boris Brezillon 2018-11-11 1211 static int nand_scan_bbt(struct nand_chip *this, struct nand_bbt_descr *bd) Linus Torvalds 2005-04-16 1212 { Boris Brezillon 2018-11-11 1213 struct mtd_info *mtd = nand_to_mtd(this); Brian Norris 2015-02-28 1214 int len, res; Linus Torvalds 2005-04-16 1215 uint8_t *buf; Linus Torvalds 2005-04-16 1216 struct nand_bbt_descr *td = this->bbt_td; Linus Torvalds 2005-04-16 1217 struct nand_bbt_descr *md = this->bbt_md; Linus Torvalds 2005-04-16 1218 Sheng Yong 2015-07-31 1219 len = (mtd->size >> (this->bbt_erase_shift + 2)) ? : 1; Brian Norris 2011-05-25 1220 /* Brian Norris 2011-05-25 1221 * Allocate memory (2bit per block) and clear the memory bad block Brian Norris 2011-05-25 1222 * table. Brian Norris 2011-05-25 1223 */ Burman Yan 2006-11-15 1224 this->bbt = kzalloc(len, GFP_KERNEL); Brian Norris 2011-06-07 1225 if (!this->bbt) Linus Torvalds 2005-04-16 1226 return -ENOMEM; Linus Torvalds 2005-04-16 1227 Brian Norris 2011-05-25 1228 /* Brian Norris 2011-05-25 1229 * If no primary table decriptor is given, scan the device to build a Brian Norris 2011-05-25 1230 * memory based bad block table. Linus Torvalds 2005-04-16 1231 */ Artem B. Bityuckiy 2005-02-11 1232 if (!td) { Boris Brezillon 2018-11-11 1233 if ((res = nand_memory_bbt(this, bd))) { Brian Norris 2011-07-19 1234 pr_err("nand_bbt: can't scan flash and build the RAM-based BBT\n"); Brian Norris 2015-02-28 @1235 goto err; Artem B. Bityuckiy 2005-02-11 1236 } Brian Norris 2015-02-28 1237 return 0; Artem B. Bityuckiy 2005-02-11 1238 } Boris Brezillon 2018-11-11 1239 verify_bbt_descr(this, td); Boris Brezillon 2018-11-11 1240 verify_bbt_descr(this, md); Linus Torvalds 2005-04-16 1241 Linus Torvalds 2005-04-16 1242 /* Allocate a temporary buffer for one eraseblock incl. oob */ Linus Torvalds 2005-04-16 1243 len = (1 << this->bbt_erase_shift); Linus Torvalds 2005-04-16 1244 len += (len >> this->page_shift) * mtd->oobsize; David Woodhouse 2006-05-13 1245 buf = vmalloc(len); Linus Torvalds 2005-04-16 1246 if (!buf) { Brian Norris 2015-02-28 1247 res = -ENOMEM; Wenwen Wang 2019-08-18 1248 goto err_free_bbt; Linus Torvalds 2005-04-16 1249 } Linus Torvalds 2005-04-16 1250 Linus Torvalds 2005-04-16 1251 /* Is the bbt at a given page? */ Linus Torvalds 2005-04-16 1252 if (td->options & NAND_BBT_ABSPAGE) { Boris Brezillon 2018-11-11 1253 read_abs_bbts(this, buf, td, md); Linus Torvalds 2005-04-16 1254 } else { Linus Torvalds 2005-04-16 1255 /* Search the bad block table using a pattern in oob */ Boris Brezillon 2018-11-11 1256 search_read_bbts(this, buf, td, md); Linus Torvalds 2005-04-16 1257 } Linus Torvalds 2005-04-16 1258 Boris Brezillon 2018-11-11 1259 res = check_create(this, buf, bd); Brian Norris 2015-02-28 1260 if (res) Wenwen Wang 2019-08-18 1261 goto err_free_buf; Linus Torvalds 2005-04-16 1262 Linus Torvalds 2005-04-16 1263 /* Prevent the bbt regions from erasing / writing */ Boris Brezillon 2018-11-11 1264 mark_bbt_region(this, td); Linus Torvalds 2005-04-16 1265 if (md) Boris Brezillon 2018-11-11 1266 mark_bbt_region(this, md); Linus Torvalds 2005-04-16 1267 David Woodhouse 2006-05-13 1268 vfree(buf); Brian Norris 2015-02-28 1269 return 0; Brian Norris 2015-02-28 1270 Wenwen Wang 2019-08-18 1271 err_free_buf: Wenwen Wang 2019-08-18 1272 vfree(buf); Wenwen Wang 2019-08-18 1273 err_free_bbt: Brian Norris 2015-02-28 1274 kfree(this->bbt); Brian Norris 2015-02-28 1275 this->bbt = NULL; Linus Torvalds 2005-04-16 1276 return res; Linus Torvalds 2005-04-16 1277 } Linus Torvalds 2005-04-16 1278 first introduced by commit mtd: nand_bbt: unify/fix error handling in nand_scan_bbt() ace@xxxxxxxxx> ace@xxxxxxxxx> Open Source Technology Center org/pipermail/kbuild-all">https://lists.01.org/pipermail/kbuild-all Intel Corporation
- Next message: Joel Fernandes (Google): "[RFC] rcu/tree: Try to invoke_rcu_core() if in_irq() during unlock"
- Previous message: Stephen Rothwell: "linux-next: Fixes tag needs some work in the net tree"
- In reply to: Wenwen Wang: "[PATCH] mtd: rawnand: Fix a memory leak bug"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]