Re: [PATCH v2] video: fbdev: Mark expected switch fall-through

[Bartlomiej Zolnierkiewicz]

On 7/30/19 5:25 PM, Anders Roxell wrote:
> Now that -Wimplicit-fallthrough is passed to GCC by default, the
> following warnings shows up:
> 
> ../drivers/video/fbdev/sh_mobile_lcdcfb.c: In function âsh_mobile_lcdc_channel_fb_initâ:
> ../drivers/video/fbdev/sh_mobile_lcdcfb.c:2086:22: warning: this statement may fall
>  through [-Wimplicit-fallthrough=]
>    info->fix.ypanstep = 2;
>    ~~~~~~~~~~~~~~~~~~~^~~
> ../drivers/video/fbdev/sh_mobile_lcdcfb.c:2087:2: note: here
>   case V4L2_PIX_FMT_NV16:
>   ^~~~
> ../drivers/video/fbdev/sh_mobile_lcdcfb.c: In function âsh_mobile_lcdc_overlay_fb_initâ:
> ../drivers/video/fbdev/sh_mobile_lcdcfb.c:1596:22: warning: this statement may fall
>  through [-Wimplicit-fallthrough=]
>    info->fix.ypanstep = 2;
>    ~~~~~~~~~~~~~~~~~~~^~~
> ../drivers/video/fbdev/sh_mobile_lcdcfb.c:1597:2: note: here
>   case V4L2_PIX_FMT_NV16:
>   ^~~~
> 
> Rework to address a warnings due to the enablement of
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>

Patch queued for v5.4, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics