Re: [PATCH 22/22] arm64: dts: qcom: sm8150: Add APSS shared mailbox

From: Vinod Koul
Date: Tue Aug 20 2019 - 02:38:35 EST


On 20-08-19, 11:50, Sibi Sankar wrote:
> Hey Vinod,
>
> There seems to be a mismatch
> between the commit description
> and the dt node (This is the
> aoss qmp node not the APPS
> shared node).

Thanks for pointing, I have squashed this and other into single patch
and updated the description

>
>
> On 2019-08-19 23:11, Vinod Koul wrote:
> > On 14-08-19, 10:17, Stephen Boyd wrote:
> > > Quoting Vinod Koul (2019-08-14 05:50:12)
> > > > @@ -338,6 +339,16 @@
> > > > #interrupt-cells = <2>;
> > > > };
> > > >
> > > > + aoss_qmp: qmp@c300000 {
> > >
> > > Node name of 'clock-controller', or 'power-controller'?
> >
> > The orignal entry for sdm845 has no such statement, but yes it doesn
> > makes sense. I am thinking power-controller.. Bjorn?
>
> aoss_qmp registers both pd and
> clock providers.

Thats correct, I chatted with Bjorn and he recommended we use power-controller

--
~Vinod