Re: [PATCH 2/4] memremap: remove the dev field in struct dev_pagemap
From: Jason Gunthorpe
Date: Tue Aug 20 2019 - 09:26:59 EST
On Mon, Aug 19, 2019 at 06:44:02PM -0700, Dan Williams wrote:
> On Sun, Aug 18, 2019 at 2:12 AM Christoph Hellwig <hch@xxxxxx> wrote:
> >
> > The dev field in struct dev_pagemap is only used to print dev_name in
> > two places, which are at best nice to have. Just remove the field
> > and thus the name in those two messages.
> >
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> > Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> Needs the below as well.
>
> /me goes to check if he ever merged the fix to make the unit test
> stuff get built by default with COMPILE_TEST [1]. Argh! Nope, didn't
> submit it for 5.3-rc1, sorry for the thrash.
>
> You can otherwise add:
>
> Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>
>
> [1]: https://lore.kernel.org/lkml/156097224232.1086847.9463861924683372741.stgit@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
Can you get this merged? Do you want it to go with this series?
Jason