Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles

[Rob Herring]

On Tue, Aug 20, 2019 at 3:21 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Tue, Aug 20, 2019 at 03:04:57PM -0500, Rob Herring wrote:
> > On Tue, Aug 20, 2019 at 1:36 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> > >
> > > On Tue, 20 Aug 2019 at 18:59, Rob Herring <robh+dt@xxxxxxxxxx> wrote:
> > > >
> > > > On Tue, Aug 20, 2019 at 10:35 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> > > > >
> > > > > Add the compatibles for Kontron i.MX6UL N6310 SoM and boards.
> > > > >
> > > > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > > > >
> > > > > ---
> > > > >
> > > > > Changes since v5:
> > > > > New patch
> > > > > ---
> > > > >  Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
> > > > >  1 file changed, 3 insertions(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > index 7294ac36f4c0..d07b3c06d7cf 100644
> > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > > > @@ -161,6 +161,9 @@ properties:
> > > > >          items:
> > > > >            - enum:
> > > > >                - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
> > > > > +              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM
> > > > > +              - kontron,imx6ul-n6310-s    # Kontron N6310 S Board
> > > > > +              - kontron,imx6ul-n6310-s-43 # Kontron N6310 S 43 Board
> > > >
> > > > This doesn't match what is in your dts files. Run 'make dtbs_check' and see.
> > >
> > > You mean the name does not match? I thought that '#' is a comment in YAML...
> >
> > No, the number of compatible strings is the problem.
>
> I see. If I understand the schema correctly, this should look like:

Looks correct, but a couple of comments.

> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 7294ac36f4c0..eb263d1ccf13 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -161,6 +161,22 @@ properties:
>          items:
>            - enum:
>                - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
> +              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM

Is the SOM ever used alone? If not, then no point in listing this here.

> +          - const: fsl,imx6ul
> +
> +      - description: Kontron N6310 S Board
> +        items:
> +          - enum:
> +              - kontron,imx6ul-n6310-s

This could be a 'const' instead. It depends if you think there will
ever be more than one entry.

> +          - const: kontron,imx6ul-n6310-som
> +          - const: fsl,imx6ul
> +
> +      - description: Kontron N6310 S 43 Board
> +        items:
> +          - enum:
> +              - kontron,imx6ul-n6310-s-43
> +          - const: kontron,imx6ul-n6310-s
> +          - const: kontron,imx6ul-n6310-som
>            - const: fsl,imx6ul
>
>        - description: i.MX6ULL based Boards
>
>
> It passes the dtbs_check. Is it correct?
>
> Best regards,
> Krzysztof
>