Re: [PATCH V2] perf/x86: Consider pinned events for group validation

[Thomas Gleixner]

On Thu, 22 Aug 2019, Andi Kleen wrote:

> > +	/*
> > +	 * Disable interrupts to prevent the events in this CPU's cpuc
> > +	 * going away and getting freed.
> > +	 */
> > +	local_irq_save(flags);
> 
> I believe it's also needed to disable preemption. Probably should
> add a comment, or better an explicit preempt_disable() too.

Preemption is implicit disabled by disabling interrupts.

Thanks,

	tglx