Re: [PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG_CORE

[Guenter Roeck]

On 8/23/19 5:45 AM, YueHaibing wrote:
> If WATCHDOG_CORE is not set, build fails:
>
> drivers/rtc/rtc-pcf2127.o: In function `pcf2127_probe.isra.6':
> drivers/rtc/rtc-pcf2127.c:478: undefined reference to `devm_watchdog_register_device'
>
> Add WATCHDOG_CORE Kconfig dependency to fix this.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Fixes: bbc597561ce1 ("rtc: pcf2127: add watchdog feature support")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>   drivers/rtc/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 25af63d..9dce7dc 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -886,6 +886,8 @@ config RTC_DRV_DS3232_HWMON
>   config RTC_DRV_PCF2127
>   	tristate "NXP PCF2127"
>   	depends on RTC_I2C_AND_SPI
> +	depends on WATCHDOG
> +	select WATCHDOG_CORE
>   	help
>   	  If you say yes here you get support for the NXP PCF2127/29 RTC
>   	  chips with integrated quartz crystal for industrial applications.