Re: [PATCH 1/2] media: imx: Move capture device init to registered

From: kbuild test robot
Date: Sat Aug 24 2019 - 07:26:10 EST


Hi Steve,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[cannot apply to v5.3-rc5 next-20190823]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Steve-Longerbeam/media-imx-Move-capture-device-init-to-registered/20190824-182241
base: git://linuxtv.org/media_tree.git master
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sparc64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

Note: the linux-review/Steve-Longerbeam/media-imx-Move-capture-device-init-to-registered/20190824-182241 HEAD 7c4284abbf1ba252792db5645a7004bd033dd3b0 builds fine.
It only hurts bisectibility.

All errors (new ones prefixed by >>):

drivers/staging/media/imx/imx-ic-prpencvf.c: In function 'prp_registered':
>> drivers/staging/media/imx/imx-ic-prpencvf.c:1274:45: error: 'ic_priv' undeclared (first use in this function); did you mean 'priv'?
priv->vdev = imx_media_capture_device_init(ic_priv->ipu_dev,
^~~~~~~
priv
drivers/staging/media/imx/imx-ic-prpencvf.c:1274:45: note: each undeclared identifier is reported only once for each function it appears in

vim +1274 drivers/staging/media/imx/imx-ic-prpencvf.c

1242
1243 /*
1244 * retrieve our pads parsed from the OF graph by the media device
1245 */
1246 static int prp_registered(struct v4l2_subdev *sd)
1247 {
1248 struct prp_priv *priv = sd_to_priv(sd);
1249 int i, ret;
1250 u32 code;
1251
1252 for (i = 0; i < PRPENCVF_NUM_PADS; i++) {
1253 priv->pad[i].flags = (i == PRPENCVF_SINK_PAD) ?
1254 MEDIA_PAD_FL_SINK : MEDIA_PAD_FL_SOURCE;
1255
1256 /* set a default mbus format */
1257 imx_media_enum_ipu_format(&code, 0, CS_SEL_YUV);
1258 ret = imx_media_init_mbus_fmt(&priv->format_mbus[i],
1259 640, 480, code, V4L2_FIELD_NONE,
1260 &priv->cc[i]);
1261 if (ret)
1262 return ret;
1263 }
1264
1265 /* init default frame interval */
1266 priv->frame_interval.numerator = 1;
1267 priv->frame_interval.denominator = 30;
1268
1269 ret = media_entity_pads_init(&sd->entity, PRPENCVF_NUM_PADS,
1270 priv->pad);
1271 if (ret)
1272 return ret;
1273
> 1274 priv->vdev = imx_media_capture_device_init(ic_priv->ipu_dev,
1275 &ic_priv->sd,
1276 PRPENCVF_SRC_PAD);
1277 if (IS_ERR(priv->vdev))
1278 return PTR_ERR(priv->vdev);
1279
1280 ret = imx_media_capture_device_register(priv->vdev);
1281 if (ret)
1282 goto remove_vdev;
1283
1284 ret = prp_init_controls(priv);
1285 if (ret)
1286 goto unreg_vdev;
1287
1288 return 0;
1289
1290 unreg_vdev:
1291 imx_media_capture_device_unregister(priv->vdev);
1292 remove_vdev:
1293 imx_media_capture_device_remove(priv->vdev);
1294 return ret;
1295 }
1296

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip