Re: [PATCHv2] lib/test_kasan: add roundtrip tests

From: Andrew Morton
Date: Sat Aug 24 2019 - 16:30:56 EST


On Fri, 23 Aug 2019 11:41:08 +0100 Mark Rutland <mark.rutland@xxxxxxx> wrote:

> >
> > /*
> >
> > which is really kinda wrong. We should strictly include linux/io.h for
> > things like virt_to_phys().
> >
> > So I think I'll stick with v1 plus my fixlet:
> >
> > --- a/lib/test_kasan.c~lib-test_kasan-add-roundtrip-tests-checkpatch-fixes
> > +++ a/lib/test_kasan.c
> > @@ -18,8 +18,8 @@
> > #include <linux/slab.h>
> > #include <linux/string.h>
> > #include <linux/uaccess.h>
> > +#include <linux/io.h>
> >
> > -#include <asm/io.h>
> > #include <asm/page.h>
> >
> > /*
> >
>
> Assuming that you mean *v3* with that fix, that looks good to me!

Yes, that's what we have.