Re: [PATCH AUTOSEL 5.2 022/123] ASoC: dapm: Fix handling of custom_stop_condition on DAPM graph walks

[Sasha Levin]

On Wed, Aug 14, 2019 at 10:20:52AM +0100, Mark Brown wrote:
> On Tue, Aug 13, 2019 at 10:09:06PM -0400, Sasha Levin wrote:
> > From: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> >
> > [ Upstream commit 8dd26dff00c0636b1d8621acaeef3f6f3a39dd77 ]
> >
> > DPCM uses snd_soc_dapm_dai_get_connected_widgets to build a
> > list of the widgets connected to a specific front end DAI so it
> > can search through this list for available back end DAIs. The
>
> The DPCM code and its users are rather fragile, if nobody noticed a
> problem I'd worry about causing some other problem to manifest by
> disturbing things.

Doesn't this patch imply that someone noticed it?

And if not, it'll just break when folks update their kernel...

If it creates other problems we should address them now rather than
later.

--
Thanks,
Sasha