Re: [PATCH v1 1/2] x86/rtc: Add option to skip using RTC

[Tanwar, Rahul]

Hi Andy,

On 23/8/2019 8:56 PM, Andy Shevchenko wrote:
> > > > get_wallclock() and set_wallclock() are function pointers of platform_ops
> > > >
> > > > which are initialized to mach_get_cmos_time() and mach_set_rtc_mmss()
> > > >
> > > > at init time. Since adding a new platform to override these functions is
> > > >
> > > > discouraged, so the only way is to modify RTC get/set functions.
> > > Shouldn't it be platform agnostic code?
> > > So, my point is, instead of hacking two functions, perhaps better to avoid them
> > > at all.
> > Sorry, i could not understand your point. The changes are platform
> >
> > agnostic i.e. it doesn't break existing use cases. Are you recommending
> >
> > to add a new platform and make changes there ?
> Nope, I propose to do something like
>
> void __init foo()
> {
> 	if (platform has RTC)
> 		return;
>
> 	set_wallclock = noop;
> 	get_wallclock = noop;
> }

Thanks. I will work out a V2 patch as per your suggestion

and send out for review again.

Regards,

Rahul