Re: [PATCH -next] ACPI: SBS: remove unused variable 'SMBUS_PEC'

From: Rafael J. Wysocki
Date: Mon Aug 26 2019 - 05:09:04 EST


On Thursday, August 22, 2019 4:43:46 PM CEST YueHaibing wrote:
> drivers/acpi/sbshc.h:18:17: warning:
> SMBUS_PEC defined but not used [-Wunused-const-variable=]
>
> SMBUS_PEC is never used since introduction in
> commit 91087dfa51a2 ("ACPI: SBS: Split host
> controller (ACPI0001) from SBS driver (ACPI0002)"),
> so just remove it.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> drivers/acpi/sbshc.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/acpi/sbshc.h b/drivers/acpi/sbshc.h
> index 06372a3..c3522bb 100644
> --- a/drivers/acpi/sbshc.h
> +++ b/drivers/acpi/sbshc.h
> @@ -15,8 +15,6 @@ enum acpi_smb_protocol {
> SMBUS_BLOCK_PROCESS_CALL = 0xd,
> };
>
> -static const u8 SMBUS_PEC = 0x80;
> -
> enum acpi_sbs_device_addr {
> ACPI_SBS_CHARGER = 0x9,
> ACPI_SBS_MANAGER = 0xa,
>

Applied, thanks!