Re: [PATCH 08/16] mips: prefer __section from compiler_attributes.h

From: Nick Desaulniers
Date: Mon Aug 26 2019 - 20:19:57 EST


On Thu, Aug 15, 2019 at 2:38 AM Paul Burton <paul.burton@xxxxxxxx> wrote:
>
> Hi Nick,
>
> On Mon, Aug 12, 2019 at 02:50:41PM -0700, Nick Desaulniers wrote:
> > Reported-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
> > Suggested-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
>
> It would be good to add a commit message, even if it's just a line
> repeating the subject & preferably describing the motivation.
>
> > ---
> > arch/mips/include/asm/cache.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/mips/include/asm/cache.h b/arch/mips/include/asm/cache.h
> > index 8b14c2706aa5..af2d943580ee 100644
> > --- a/arch/mips/include/asm/cache.h
> > +++ b/arch/mips/include/asm/cache.h
> > @@ -14,6 +14,6 @@
> > #define L1_CACHE_SHIFT CONFIG_MIPS_L1_CACHE_SHIFT
> > #define L1_CACHE_BYTES (1 << L1_CACHE_SHIFT)
> >
> > -#define __read_mostly __attribute__((__section__(".data..read_mostly")))
> > +#define __read_mostly __section(.data..read_mostly)
> >
> > #endif /* _ASM_CACHE_H */
> > --
> > 2.23.0.rc1.153.gdeed80330f-goog
>
> I'm not copied on the rest of the series so I'm not sure what your
> expectations are about where this should be applied. Let me know if
> you'd prefer this to go through mips-next, otherwise:
>
> Acked-by: Paul Burton <paul.burton@xxxxxxxx>

Thanks Paul, going to send this up via Miguel's tree, if you don't
mind. Updating my series now. (Will probably avoid running
get_maintainer.pl on every patch...too hard to cc everyone on the
whole series).
--
Thanks,
~Nick Desaulniers