Re: [PATCH v6 3/4] media: venus: Update to bitrate based clock scaling

[amasule]

Hi Stan,

On 2019-07-29 17:08, Stanimir Varbanov wrote:
> Hi,
>
> On 7/22/19 12:07 PM, Aniket Masule wrote:
> > Introduced clock scaling using bitrate, preavious
> > calculations consider only the cycles per mb.
> > Also, clock scaling is now triggered before every
> > buffer being queued to the device. This helps in
> > deciding precise clock cycles required.
> >
> > Signed-off-by: Aniket Masule <amasule@xxxxxxxxxxxxxx>
> > ---
> >  drivers/media/platform/qcom/venus/helpers.c | 33 
> > +++++++++++++++++++++++++----
> >  1 file changed, 29 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/media/platform/qcom/venus/helpers.c 
> > b/drivers/media/platform/qcom/venus/helpers.c
> > index 2c976e4..edf403d 100644
> > --- a/drivers/media/platform/qcom/venus/helpers.c
> > +++ b/drivers/media/platform/qcom/venus/helpers.c
> > @@ -399,17 +399,26 @@ static int scale_clocks(struct venus_inst *inst)
> >  	return ret;
> >  }
> >
> > -static unsigned long calculate_vpp_freq(struct venus_inst *inst)
> > +static unsigned long calculate_inst_freq(struct venus_inst *inst,
> > +					 unsigned long filled_len)
> >  {
> > -	unsigned long vpp_freq = 0;
> > +	unsigned long vpp_freq = 0, vsp_freq = 0;
> > +	u64 fps = inst->fps;
> >  	u32 mbs_per_sec;
> >
> >  	mbs_per_sec = load_per_instance(inst);
> >  	vpp_freq = mbs_per_sec * inst->clk_data.codec_freq_data->vpp_freq;
> >  	/* 21 / 20 is overhead factor */
> >  	vpp_freq += vpp_freq / 20;
> > +	vsp_freq = mbs_per_sec * inst->clk_data.codec_freq_data->vsp_freq;
> >
> > -	return vpp_freq;
> > +	/* 10 / 7 is overhead factor */
> > +	if (inst->session_type == VIDC_SESSION_TYPE_ENC)
> > +		vsp_freq += (inst->controls.enc.bitrate * 10) / 7;
> > +	else
> > +		vsp_freq += ((fps * filled_len * 8) * 10) / 7;
>
> load_per_instance() already taken into account fps, thus I think fps
> should be excluded from calculation.
I will correct this, fps is needed for stream processor frequency 
calculations,
also fps is not needed for vpp.
> > +
> > +	return max(vpp_freq, vsp_freq);
> >  }

Regards,
Aniket